fix: check label_selector child targets with load_balancer_status filter #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgets The previous implementation did not take into consideration label selectors, and their child targets. This change implements a recursive function that traverse all the targets.
apricote
approved these changes
Aug 16, 2024
jooola
pushed a commit
that referenced
this pull request
Aug 30, 2024
🤖 I have created a release *beep* *boop* --- ## [4.2.0](4.1.0...4.2.0) (2024-08-30) ### Features * compute load balancer targets status using a filter ([#550](#550)) ([fce8bc9](fce8bc9)) ### Bug Fixes * check label_selector child targets with load_balancer_status filter ([#552](#552)) ([abdf722](abdf722)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The previous implementation did not take into consideration label selectors targets, and their child targets.
This change implements a recursive function that traverse all the targets.
Related to #467 #550